Skip to content

Commit

Permalink
Updated opentelemetry-metrics-sdk based on changes from my comment op…
Browse files Browse the repository at this point in the history
  • Loading branch information
daveknapik committed Apr 24, 2024
1 parent ddbf1e2 commit 22ab92d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
GIT
remote: https://github.com/daveknapik/opentelemetry-ruby.git
revision: da09c44596fc899dcc10ea5fee017199a908a27b
revision: 63405d53402f2f432288c3ff793557d70f7497a4
branch: periodic-reader
glob: metrics_sdk/*.gemspec
specs:
Expand All @@ -24,7 +24,7 @@ GIT

GIT
remote: https://github.com/open-telemetry/opentelemetry-ruby.git
revision: 6bae4e1a2b6f05b673a3e7241d91e56acad2c8e9
revision: a1f1629abb7c87ae316cf0f4541111e48e433d67
glob: metrics_api/*.gemspec
specs:
opentelemetry-metrics-api (0.0.1)
Expand Down Expand Up @@ -202,8 +202,8 @@ GEM
faraday (>= 2.0.1)
faraday-multipart
hashie
opentelemetry-api (1.2.3)
opentelemetry-common (0.20.0)
opentelemetry-api (1.2.5)
opentelemetry-common (0.20.1)
opentelemetry-api (~> 1.0)
opentelemetry-exporter-otlp (0.26.3)
google-protobuf (~> 3.14)
Expand Down Expand Up @@ -396,9 +396,9 @@ GEM
opentelemetry-helpers-sql-obfuscation
opentelemetry-instrumentation-base (~> 0.22.1)
opentelemetry-semantic_conventions (>= 1.8.0)
opentelemetry-registry (0.3.0)
opentelemetry-registry (0.3.1)
opentelemetry-api (~> 1.1)
opentelemetry-sdk (1.3.1)
opentelemetry-sdk (1.4.1)
opentelemetry-api (~> 1.1)
opentelemetry-common (~> 0.20)
opentelemetry-registry (~> 0.2)
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/opentelemetry.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
otlp_metric_exporter = OpenTelemetry::Exporter::OTLP::MetricsExporter.new

# create a periodic reader for metrics and pair it with the exporter
metric_reader = OpenTelemetry::SDK::Metrics::Export::PeriodicMetricReader.new(interval_millis: 60, timeout_millis: 10, exporter: console_exporter)
metric_reader = OpenTelemetry::SDK::Metrics::Export::PeriodicMetricReader.new(export_interval: 60, export_timeout: 10, exporter: console_exporter)

# pair the reader with the provider
OpenTelemetry.meter_provider.add_metric_reader(metric_reader)
Expand Down

0 comments on commit 22ab92d

Please sign in to comment.