-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional classes #6
Conversation
Shouldn't have the underscore, no need for any other characters apart from letters and numbers IMO. |
I really like your solution, but I politely disagree that it only needs to be alphanumeric. I think the plugin should do its best accomodate non-English languages like Japanese or that weird German I also thing supporting punctuations like amperstands, quotes, and exclamation points would be extremely useful typographically. What might be smart is to roll out a |
Yeah I totally overlooked typography for non alphanumerics! I think the HTML entity equivalents would be the best solution i.e. standard quotes could be represented by .charquot, or perhaps just .quot, .amp for &, etc. I think things get complex for full UTF 8 support however. It's getting late in England though, so I think I might revisit this tomorrow. Anyway great work on the plugin! |
I'm not too fond of this particular class-name based approach. |
Going to put momentum here into #45. Thanks for your original commits @drpheltright. Appreciate it. |
I have added additional classes for styling particular characters, words and sentences by their contents and not just a counter. This allows font changes for certain letters and numbers, easier control over sentences (as long as the contents does not change), etc.
Luke