Get curl command line for a request #80

daurnimator · 2017-08-18T10:29:27Z

WIP

Open Questions:

How to handle non-string bodies?

… as a curl command line

curl/curl@b4a3949

… pass -g

…t we update referer on redirects

…ns if redirects are disabled

daurnimator · 2017-08-18T10:29:40Z

Can now add paths that start with non-/ chars https://daniel.haxx.se/blog/2017/06/19/options-with-curl/

coveralls · 2017-08-18T10:37:52Z

Coverage increased (+0.08%) to 88.008% when pulling 953c1cc on http.request.tocurl into e79ad71 on master.

daurnimator · 2018-08-27T08:19:26Z

http/request.lua

+				end
+			end
+		elseif name == "user-agent" then
+			cmd[n+1] = "-A"


If user agent not set then need to tell curl not to send one. -H "User-Agent;"

daurnimator · 2018-08-27T08:22:16Z

http/request.lua

+			n = n + 2
+		end
+	end
+


Need to tell curl to not send Accept if we don't set that header ourselves.

daurnimator added 19 commits January 20, 2016 14:48

http.request: Add :to_curl method that returns the equivalent request…

21360f1

… as a curl command line

http.request: :to_curl: fix command line escaping

bf2e5ca

http.request: :to_curl better comments

e66c5f3

http/request: Fix NYI. curl gained a flag for setting the expect timeout

588e655

curl/curl@b4a3949

Merge branch 'master' into http.request.tocurl

5a7ae9d

http.request: Reorder checks in to_curl

60e039d

http.request: :to_curl: add support for post301 and post302 options

40d81ca

http.request: :to_curl: Don't return --post303

f264b44

http.request: :to_curl: add support for (maps to --location-trusted)

6b147be

http/request: :to_curl: if URL contains a curl-globbable character,…

54c0d9d

… pass -g

http/request: :to_curl: Validate path is okay for curl

84bb632

http/request: :to_curl: handle .version field

2926c01

http/request: :to_curl: Add -e ;auto to command lines reflect tha…

c4df6a4

…t we update referer on redirects

http/request: :to_curl: Don't bother setting redirect related optio…

c0da486

…ns if redirects are disabled

Merge branch 'master' into http.request.tocurl

7166c1c

spec/request_spec: Add tests for :to_curl()

d09cd72

http/request: Fix incorrect assert for validating referer

9deed93

spec/request_spec: Add more tests for :to_curl()

7844940

http/request: Have :to_curl() pay attention to proxies

953c1cc

daurnimator added the WIP label Aug 18, 2017

daurnimator commented Aug 27, 2018

View reviewed changes

http/request.lua

n = n + 2

end

end

Copy link

Owner Author

daurnimator Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tell curl to not send Accept if we don't set that header ourselves.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get curl command line for a request #80

Get curl command line for a request #80

daurnimator commented Aug 18, 2017 •

edited

Loading

daurnimator commented Aug 18, 2017

coveralls commented Aug 18, 2017 •

edited

Loading

daurnimator Aug 27, 2018

daurnimator Aug 27, 2018

Get curl command line for a request #80

Are you sure you want to change the base?

Get curl command line for a request #80

Conversation

daurnimator commented Aug 18, 2017 • edited Loading

daurnimator commented Aug 18, 2017

coveralls commented Aug 18, 2017 • edited Loading

daurnimator Aug 27, 2018

Choose a reason for hiding this comment

daurnimator Aug 27, 2018

Choose a reason for hiding this comment

daurnimator commented Aug 18, 2017 •

edited

Loading

coveralls commented Aug 18, 2017 •

edited

Loading