New version: 3.3.4 w/ integer ID fix #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just bumping the version number to prep a release for the integer ID fix (#28)
|
Done @arcataroger |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stefanoverna or @matjack1 Could we please put out a new version release to publish the fix at #28)? A customer is waiting for it (https://community.datocms.com/t/best-way-to-handle-not-found-on-itemid-lookups/5148/7?u=roger)
This change should be considered a bugfix, IMO. The
isValidId()function was previously rejecting integer IDs even though they were valid. That's been fixed. UUID-style IDs continue to work as before.I don't believe I have credentials to publish to NPM directly. Would you mind taking a sec to do that after merging this PR, please?
Thanks!