Fix impossible blob name check #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcataroger
commented
Mar 22, 2024
Comment on lines
+37
to
+45
| let filename: string; | ||
|
|
||
| if (options.filename) { | ||
| // If a filename is explicitly provided, use it | ||
| filename = options.filename; | ||
| } else if (fileOrBlob instanceof File && fileOrBlob.name) { | ||
| // Files extend Blobs and may have a `name` property. Blobs never have names. | ||
| filename = fileOrBlob.name; | ||
| } else { |
There was a problem hiding this comment.
We could've also just changed the && to || in the original if, but then that will cause the later line filename = options.filename || fileOrBlob.name to have a TypeScript error, because blobs can never have names.
I think this is more explicit than adding a ts-ignore
|
Fixed here! 580affc |
|
(good catch btw!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes an issue with being able to upload JS
Blobs, as reported on the forum: https://community.datocms.com/t/createupload-fails-with-missing-filename/4886/We had an
ifstatement:This would always be false if
fileOrBlobwas aBlob, becauseBlobsdon't have anameproperty (onlyFilesdo).