Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'KRAFT GmbH' (community contribution) #2924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datenanfragen-community-edits
Copy link
Collaborator

@datenanfragen-community-edits datenanfragen-community-edits commented Nov 19, 2024

This suggestion was submitted through the website.

Edit in: company JSON generator, data editor1

Footnotes

  1. Closed beta

"commerce"
],
"name": "KRAFT GmbH",
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (74592 Kirchberg an der Jagst) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst",
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst\nGermany",
Suggested change
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst",
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst\nDeutschland",

],
"name": "KRAFT GmbH",
"address": "Von-Humboldt-Straße 9\n74592 Kirchberg an der Jagst",
"phone": "00497904943600",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "00497904943600"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

2 participants