This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
String methods #270
Open
itamarst
wants to merge
12
commits into
q2
Choose a base branch
from
itamarst/string-methods
base: q2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
String methods #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you saying now that "objects", i.e. implementations of interfaces are now also compared by-value by assertEqual, e.g. if I do I am going to try this now just for giggles. ;-) |
Ok, this fails on Go and Javascript (and passes everywhere else): class Foo {}
void test_identity() {
assertNotEqual(new Foo(), new Foo());
} |
ark3
reviewed
Dec 7, 2016
@@ -304,6 +304,87 @@ class StringTest { | |||
assertEqual(false, "abc" == "def"); | |||
} | |||
|
|||
void upper_lower() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than growing primitives.q even more, can we put these type-specific tests into separate quark files? Maybe something like bi_string.q
(for built-in) or lib_list.q
or whatever? Something consistent would be great.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most worrisome change here is changing the way assertEqual works on Javascript and Go. If there are places where asserting identity matters then we should add assertIdentical and use it where appropriate.