Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect query count in index metrics #1520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

k-rus
Copy link

@k-rus k-rus commented Jan 17, 2025

What is the issue

Part of https://github.com/riptano/cndb/issues/9594

What does this PR fix and why was it fixed

Implements counting queries for each index in metrics. Adds unit tests for some cases

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

k-rus added 2 commits January 16, 2025 12:08
It still needs to be set and updated. A plan can have several
restrictions and thus several usage of the same and different indexes.
Thus it's necessary to implement duplicate elimination in the phase
after running the optimizer, which reduces index usages.

Two approaches: (1) revisit the plan after the optimizing away, (2)
maintain actual unique indexes during planning.
Implements counting queries for each index in metrics. Adds unit tests
for some cases.
@k-rus k-rus force-pushed the rf-cndb-9594-index-metrics-queries branch from 9175eef to b13631e Compare January 18, 2025 11:53
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1520 rejected by Butler


1 new test failure(s) in 2 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
...rint,varint>,wide=false,scenario=SSTABLE_QUERY] regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 5 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants