Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12434: Fix flaky CQLCompressionTest failures #1512

Merged
merged 1 commit into from
Jan 27, 2025
Merged

CNDB-12434: Fix flaky CQLCompressionTest failures #1512

merged 1 commit into from
Jan 27, 2025

Conversation

jkni
Copy link

@jkni jkni commented Jan 16, 2025

What is the issue

CQLCompressionTest experiences flaky test failures when 3 sstables are detected rather than the expected 2.

What does this PR fix and why was it fixed

This PR switches back to inserting single rows before triggering flushes in the test. Multiple rows were needed due to UCS's previous maximal compaction behavior, but if an asynchronous CQLTester schema change dropped a table while rows were being inserted, an additional flush could be trigger in the middle of inserting multiple rows. This would generate more sstables than expected. Since multiple rows are no longer needed after #1342 due to changes in UCS behavior, we can revert to the previous behavior and avoid the flakiness without waiting for schema changes to complete between tests.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

…s multiple rows are no longer needed and caused flaky test failures due to asynchronous CQLTester schema drops
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1512 rejected by Butler


2 new test failure(s) in 1 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
o.a.c.i.s.c.VectorCompactionTest.testPQRefine[ca] regression 🔴 🔵🔵🔵🔵
...et=map<int,int>,wide=true,scenario=MIXED_QUERY] regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 5 known test failures

@jkni jkni added the core-team label Jan 21, 2025
@jtgrabowski
Copy link

@jkni
Copy link
Author

jkni commented Jan 27, 2025

@jtgrabowski yes, I saw that, and the CQLTester fix would also resolve this. I think we might as well merge as it reduces divergence from apache/cassandra in case we end up debugging this for some reason in the future.

@jkni jkni merged commit 822405f into main Jan 27, 2025
466 of 479 checks passed
@jkni jkni deleted the CNDB-12434 branch January 27, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants