CNDB-12434: Fix flaky CQLCompressionTest failures #1512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
CQLCompressionTest experiences flaky test failures when 3 sstables are detected rather than the expected 2.
What does this PR fix and why was it fixed
This PR switches back to inserting single rows before triggering flushes in the test. Multiple rows were needed due to UCS's previous maximal compaction behavior, but if an asynchronous CQLTester schema change dropped a table while rows were being inserted, an additional flush could be trigger in the middle of inserting multiple rows. This would generate more sstables than expected. Since multiple rows are no longer needed after #1342 due to changes in UCS behavior, we can revert to the previous behavior and avoid the flakiness without waiting for schema changes to complete between tests.
Checklist before you submit for review
NoSpamLogger
for log lines that may appear frequently in the logs