Skip to content

Commit

Permalink
Adding additional step of building and loading CSI plugins before int…
Browse files Browse the repository at this point in the history
…egration test

Signed-off-by: SRIKUMAR VENUGOPAL <[email protected]>
  • Loading branch information
srikumar003 committed Nov 21, 2024
1 parent 7d8abb5 commit 0a216da
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 23 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ jobs:
run: |
cd build-tools
./build_components.sh
- name: Build CSI plugins
shell: bash
run: |
cd build-tools
./build_csi_plugins.sh
- name: Make Datashim manifests
run: make manifests
- name: Update manifests to use local images
Expand All @@ -38,6 +43,8 @@ jobs:
run: |
kind load docker-image -n chart-testing quay.io/datashim-io/dataset-operator:latest
kind load docker-image -n chart-testing quay.io/datashim-io/generate-keys:latest
kind load docker-image -n chart-testing quay.io/datashim-io/csi-s3:latest
kind load docker-image -n chart-testing quay.io/datashim-io/csi-nfs:latest
- name: Install Datashim
run: make deployment
- name: Wait for Datashim
Expand Down
6 changes: 3 additions & 3 deletions build-tools/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ ARCH ?= $(shell go env GOARCH)

#used only when building the plugins

EXTERNAL_ATTACHER_TAG ?= v3.3.0
EXTERNAL_PROVISIONER_TAG ?= v2.2.2
NODE_DRIVER_REGISTRAR_TAG ?= v2.3.0
EXTERNAL_ATTACHER_TAG ?= v4.7.0
EXTERNAL_PROVISIONER_TAG ?= v5.1.0
NODE_DRIVER_REGISTRAR_TAG ?= v2.12.0

include helpers.mk

Expand Down
10 changes: 5 additions & 5 deletions release-tools/manifests/dlf-ibm-k8s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ spec:
hostNetwork: true
containers:
- name: node-driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
lifecycle:
preStop:
exec:
Expand Down Expand Up @@ -1046,7 +1046,7 @@ spec:
serviceAccountName: csi-s3
containers:
- name: driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1239,7 +1239,7 @@ spec:
serviceAccountName: csi-attacher-nfs
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
args:
- "--v=10"
- "--csi-address=$(ADDRESS)"
Expand Down Expand Up @@ -1303,7 +1303,7 @@ spec:
serviceAccountName: csi-attacher
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1350,7 +1350,7 @@ spec:
serviceAccountName: csi-provisioner
containers:
- name: csi-provisioner
image: "k8s.gcr.io/sig-storage/csi-provisioner:v2.2.2"
image: "registry.k8s.io/sig-storage/csi-provisioner:v5.1.0"
imagePullPolicy: Always
args:
- -v=5
Expand Down
10 changes: 5 additions & 5 deletions release-tools/manifests/dlf-ibm-oc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ spec:
hostNetwork: true
containers:
- name: node-driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
lifecycle:
preStop:
exec:
Expand Down Expand Up @@ -1046,7 +1046,7 @@ spec:
serviceAccountName: csi-s3
containers:
- name: driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1239,7 +1239,7 @@ spec:
serviceAccountName: csi-attacher-nfs
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
args:
- "--v=10"
- "--csi-address=$(ADDRESS)"
Expand Down Expand Up @@ -1303,7 +1303,7 @@ spec:
serviceAccountName: csi-attacher
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1350,7 +1350,7 @@ spec:
serviceAccountName: csi-provisioner
containers:
- name: csi-provisioner
image: "k8s.gcr.io/sig-storage/csi-provisioner:v2.2.2"
image: "registry.k8s.io/sig-storage/csi-provisioner:v5.1.0"
imagePullPolicy: Always
args:
- -v=5
Expand Down
10 changes: 5 additions & 5 deletions release-tools/manifests/dlf-oc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ spec:
hostNetwork: true
containers:
- name: node-driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
lifecycle:
preStop:
exec:
Expand Down Expand Up @@ -1046,7 +1046,7 @@ spec:
serviceAccountName: csi-s3
containers:
- name: driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1239,7 +1239,7 @@ spec:
serviceAccountName: csi-attacher-nfs
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
args:
- "--v=10"
- "--csi-address=$(ADDRESS)"
Expand Down Expand Up @@ -1303,7 +1303,7 @@ spec:
serviceAccountName: csi-attacher
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1350,7 +1350,7 @@ spec:
serviceAccountName: csi-provisioner
containers:
- name: csi-provisioner
image: "k8s.gcr.io/sig-storage/csi-provisioner:v2.2.2"
image: "registry.k8s.io/sig-storage/csi-provisioner:v5.1.0"
imagePullPolicy: Always
args:
- -v=5
Expand Down
10 changes: 5 additions & 5 deletions release-tools/manifests/dlf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ spec:
hostNetwork: true
containers:
- name: node-driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
lifecycle:
preStop:
exec:
Expand Down Expand Up @@ -1046,7 +1046,7 @@ spec:
serviceAccountName: csi-s3
containers:
- name: driver-registrar
image: "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
image: "registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1239,7 +1239,7 @@ spec:
serviceAccountName: csi-attacher-nfs
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
args:
- "--v=10"
- "--csi-address=$(ADDRESS)"
Expand Down Expand Up @@ -1303,7 +1303,7 @@ spec:
serviceAccountName: csi-attacher
containers:
- name: csi-attacher
image: "k8s.gcr.io/sig-storage/csi-attacher:v3.3.0"
image: "registry.k8s.io/sig-storage/csi-attacher:v4.7.0"
imagePullPolicy: Always
args:
- --v=5
Expand Down Expand Up @@ -1350,7 +1350,7 @@ spec:
serviceAccountName: csi-provisioner
containers:
- name: csi-provisioner
image: "k8s.gcr.io/sig-storage/csi-provisioner:v2.2.2"
image: "registry.k8s.io/sig-storage/csi-provisioner:v5.1.0"
imagePullPolicy: Always
args:
- -v=5
Expand Down

0 comments on commit 0a216da

Please sign in to comment.