Skip to content

Commit

Permalink
Fix clean shutdown with docker kill
Browse files Browse the repository at this point in the history
By using "docker kill" to stop the core it will bluntly stop the core. A
graceful shutdown will be be performed because it sends SIGKILL which
cannot be trapped.

The "docker kill --signal SIGINT" command should be used instead, but
this requires that the core is root process in the image. The run.sh
shell script process has to be replaced by the core process, otherwise
the SIGINT will not reach the core.
  • Loading branch information
ioppermann committed Sep 21, 2023
1 parent 63714de commit 477243a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ fi

# Now run the core with the possibly converted configuration.

./bin/core
exec ./bin/core

0 comments on commit 477243a

Please sign in to comment.