refactor(smoke): use pytest.raises instead of custom solution #12333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes our tests clearer, and ensures that we're throwing the right types of exceptions. `except Exception` is very risky and often will catch things you didn't want to suppress.
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
datahub-cyborg
bot
added
the
needs-review
mayurinehate
approved these changes
Jan 21, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
|
This PR only impacts smoke tests, not cypress tests. Merging through CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes our tests clearer, and ensures that we're throwing the right types of exceptions.
except Exceptionis very risky and often will catch things you didn't want to suppress.Checklist