Add iceberg feature
#256
Open
Add iceberg feature
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmturner
commented
Dec 3, 2024
There was a problem hiding this comment.
I hate that i had to make this constructor async. I think I will take a different approach and add a new async method like register_extensions that does this.
matthewmturner
commented
Dec 3, 2024
Comment on lines
+119
to
+131
| pub async fn register_extensions(&mut self) -> Result<()> { | ||
| let ctx = &mut self.session_ctx; | ||
| let config = &self.config; | ||
| let extensions = enabled_extensions(); | ||
| // Apply any additional setup to the session context (e.g. registering | ||
| // functions) | ||
| for extension in &extensions { | ||
| extension.register_on_ctx(config, ctx)?; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
New method for registering extensions
matthewmturner
commented
Dec 3, 2024
| ) -> datafusion_common::Result<DftSessionStateBuilder> { | ||
| Ok(builder.with_table_factory("ICEBERG", Arc::new(IcebergTableProviderFactory {}))); | ||
|
|
||
| let catalog_provider = IcebergCatalogProvider::try_new(catalog).await?; |
There was a problem hiding this comment.
This await is what required the async changes for registering extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.