Dataprep sqlx support #1891
Dataprep sqlx support #1891
Conversation
fernst
force-pushed
the
dataprep-sqlx-support
branch
from
93ec3e1 to
accdf6d
Compare
fernst
requested review from
Ekrekr and
kolina
and removed request for
Tuseeq1
# Conflicts: # core/utils.ts
fernst
force-pushed
the
dataprep-sqlx-support
branch
from
accdf6d to
1307b28
Compare
| } from "df/core/utils"; | ||
| import { dataform } from "df/protos/ts"; | ||
|
|
||
| // Brings the properties for the destination table | ||
| export interface IDataPreparationConfig |
There was a problem hiding this comment.
Elias is getting rid of non-proto action configs. So I think you should not create this for new SQLX actions.
There was a problem hiding this comment.
Does it make sense to remove these now, or wait until all other configs are removed as well?
There was a problem hiding this comment.
It's better to not use a legacy way if you can afford it.
There was a problem hiding this comment.
Yes please, stick to proto at the source of truth where possible. Remaining actions following this were converted in #1780
| dataPreparationSqlx | ||
| ); | ||
|
|
||
| const result = runMainInVm(coreExecutionRequestFromPath(projectDir)); |
There was a problem hiding this comment.
should you pass actual overrides here?
|
|
||
| FROM x | ||
| -- Ensure y is positive | ||
| $\{validate("y > 0")\} |
There was a problem hiding this comment.
I'd add other context functions usage to validate that they're working.
| @@ -98,5 +98,6 @@ | |||
| "**/nth-check": "^2.0.1", | |||
| "**/node-fetch": "^2.6.7", | |||
| "**/markdown-it": "^12.3.2" | |||
| } | |||
| }, | |||
| "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | |||
| } from "df/core/utils"; | ||
| import { dataform } from "df/protos/ts"; | ||
|
|
||
| // Brings the properties for the destination table | ||
| export interface IDataPreparationConfig |
There was a problem hiding this comment.
Yes please, stick to proto at the source of truth where possible. Remaining actions following this were converted in #1780
No description provided.