drop bespoke mat, intro simpler macros #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
benc-db
reviewed
Oct 11, 2023
| @@ -0,0 +1,3 @@ | |||
| {% macro databricks__get_rename_materialized_view_sql(relation, new_name) %} | |||
| alter materialized view {{ relation }} rename to {{ new_name }} | |||
There was a problem hiding this comment.
MVs in Databricks cannot be renamed. What should we do instead?
benc-db
reviewed
Oct 11, 2023
| create materialized view if not exists {{ relation }} as {{ sql }}; | ||
|
|
||
| {% for _index_dict in config.get('indexes', []) -%} | ||
| {{- get_create_index_sql(relation, _index_dict) -}} |
There was a problem hiding this comment.
Databricks doesn't have traditional indexes.
|
This is more what I was expecting. But are you saying even this is not required for 1.7.0? Or is this level what we need for 1.7.0, and the more substantial refactor is 1.7.x timeline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves databricks#477 (partially)
I'm guessing that the CRUD macros for tables and views will also need to be added to get this working properly. See dbt-postgres's versions in the
table/andview/directories withinmain/plugins/postgres/dbt/include/postgres/macros/relations. Other adapters (Snowflake, Redshift, and soon BQ) will have the same macros all will require this work