Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added explicit forward dependencies for libraries #6

Open
wants to merge 5 commits into
base: tcmalloc-fixes
Choose a base branch
from
Open

Added explicit forward dependencies for libraries #6

wants to merge 5 commits into from

Conversation

jeremybarnes
Copy link

Allow a forward dependency for a library to be specified like so:

$(eval $(call library,mylib,...,laterlib))
$(eval $(call library_forward_dependency,mylib,laterlib))
...
$(eval $(call library,laterlib,...))

It works because after the $(call libary,mylib...) is eval'd, its so name is in LIB_mylib_SO, and so the dependency can be fully specified.

@jeremybarnes
Copy link
Author

@RAttab please review

@RAttab
Copy link

RAttab commented Nov 30, 2014

+1

jraby and others added 4 commits February 6, 2015 10:18
@jraby
Override BUILD_CONTAINER_LOCAL when building docker
cdbe593 
this should change in the future...
@jraby
Override ALTROOT when building docker
7065a61 
Also split altroot preparation (build)from actual docker creation
@jraby
Rewrite docker_install_inside_container.sh
dc0bc7d 
 - Fail on first error
 - cd in the altroot directory and copy everything as is at the root
   of the container
Refactored to_junit to use xml lib instead of raw print, fixed utf8 t…
f6921fa 
…o ascii for xml header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremybarnes @RAttab @jraby