Enhance error reporting and handling for large JSON validations #505
+116
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pascalrosenberger / @ManbirP / @hirschsebastian could please review the PR, before I will change the status from draft to finish? |
| logging.info("Validating JSON") | ||
| for json_obj in json_stream: | ||
|
|
||
| def get_primary_key_field(schema: dict, model_name: str) -> str: |
There was a problem hiding this comment.
Since primary_key_field can be theoretically None, I suggest to set as a return type Optional[str].
| return primary_key_field | ||
|
|
||
|
|
||
| def get_primary_key_value(schema: dict, model_name: str, json_object: dict) -> str: |
There was a problem hiding this comment.
Since the return value can be theoretically None, I suggest to set as a return type Optional[str].
| model=exception.model, | ||
| engine=exception.engine, | ||
| message=exception.message, | ||
| ) |
There was a problem hiding this comment.
Since we use a property message here, I suggest to add the property to the Check class as Optional[str].
hirschsebastian
suggested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #443