add submenu items for overview page for places without subtopics pages (

#606) Co-authored-by: beets <[email protected]>
datacommonsorg · Oct 15, 2020 · d1390b0 · d1390b0
1 parent a6c4f0b
commit d1390b0
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/static/js/place/topic_menu.tsx b/static/js/place/topic_menu.tsx
@@ -30,11 +30,15 @@ class MenuCategory extends React.Component<MenuCategoryPropsType, unknown> {
     const selectCategory = this.props.selectCategory;
     const category = this.props.category;
     const topics = this.props.topics;
+    const hrefString =
+      category === "Overview"
+        ? `/place/${dcid}`
+        : `/place/${dcid}?topic=${category}`;
 
     return (
       <li className="nav-item">
         <a
-          href={`/place/${dcid}?topic=${category}`}
+          href={hrefString}
           className={`nav-link ${selectCategory === category ? "active" : ""}`}
         >
           {category}
@@ -49,10 +53,7 @@ class MenuCategory extends React.Component<MenuCategoryPropsType, unknown> {
             {topics.map((topic: string) => {
               return (
                 <li className="nav-item" key={topic}>
-                  <a
-                    href={`/place/${dcid}?topic=${category}#${topic}`}
-                    className="nav-link"
-                  >
+                  <a href={`${hrefString}#${topic}`} className="nav-link">
                     {topic}
                   </a>
                 </li>
@@ -76,19 +77,22 @@ class Menu extends React.Component<MenuPropsType, unknown> {
     const dcid = this.props.dcid;
     const topic = this.props.topic;
     const categories = Object.keys(this.props.pageChart);
+    const showOverviewSubmenu = categories.length === 1;
     return (
       <ul id="nav-topics" className="nav flex-column accordion">
-        <li className="nav-item">
-          <a
-            href={`/place/${dcid}`}
-            className={`nav-link ${!topic ? "active" : ""}`}
-          >
-            Overview
-          </a>
-        </li>
+        {showOverviewSubmenu ? null : (
+          <li className="nav-item">
+            <a
+              href={`/place/${dcid}`}
+              className={`nav-link ${!topic ? "active" : ""}`}
+            >
+              Overview
+            </a>
+          </li>
+        )}
         {categories.map((category: string) => {
           const topics = Object.keys(this.props.pageChart[category]);
-          if (category !== "Overview") {
+          if (showOverviewSubmenu || category !== "Overview") {
             return (
               <MenuCategory
                 key={category}