-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature streaming enhancments #127
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 51adf39 into 23a83f5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 46f8406 into 83c5ed4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e0f7887 into d6b1799 - view on LGTM.com new alerts:
|
Need to update test process to test on specific Databricks builds or open source Spark equivalent |
This pull request introduces 1 alert when merging 2b3060e into 109707e - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1b91312 into 981a5a4 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Note v0.3.1 is the release for the target version to incorporate these changes. |
merge from master
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 91.97% 90.25% -1.73%
==========================================
Files 23 23
Lines 2680 2637 -43
Branches 452 438 -14
==========================================
- Hits 2465 2380 -85
- Misses 128 165 +37
- Partials 87 92 +5
|
|
Proposed changes
Added support for rate-micro-batch source
Added ageLimit option for rate source
More extensive testing for streaming scenarios
Note: still work in progress - PR opened to validate unit tests on GitHub build runner
Types of changes
What types of changes does your code introduce to dbldatagen?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...