Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Checking #141

Merged
merged 19 commits into from
Aug 28, 2024
Merged

Type Checking #141

merged 19 commits into from
Aug 28, 2024

Conversation

eitanturok
Copy link
Contributor

What does this PR do?

Add type checking.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eitanturok eitanturok requested a review from mihir-db August 27, 2024 03:05
@eitanturok eitanturok marked this pull request as ready for review August 28, 2024 16:47
@eitanturok
Copy link
Contributor Author

Ready for a review. There are still ~300 type checking errors. I'm going to address those in a follow up PR.

@mihir-db mihir-db merged commit 5b2650a into databricks:main Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants