Another attempt to improve metadata gathering performance #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db,
susodapop and
rcypher-databricks
as code owners
rcypher-databricks
previously approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #496, I hope
Description
So we think when no models are selected, stuffing the where clause with every model is probably non-performant. In dbt core, they'll only call get_catalog if no models are selected, or there are more than 100 models selected. In this case, we can filter by schemas, but probably a bad idea to make our optimizer try to handle a where clause with 200+ components.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.