Vectorizer and Label Encoder Changes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khoroshevskyi
approved these changes
Sep 16, 2024
| :return nn.Module: Loaded Neural Network Model. | ||
| :return object: The scikit learn vectorizer for bag of words encoding. | ||
| :return object: Label encoder object for the labels (y). |
nleroy917
requested changes
Sep 16, 2024
bedms/attr_standardizer.py
Outdated
| ) | ||
|
|
||
| def _load_model(self) -> nn.Module: | ||
| def _load_model(self) -> tuple[nn.Module, object, object]: |
There was a problem hiding this comment.
Is this syntax (tuple[...]) supported? Do we not need typing.Tuple?
There was a problem hiding this comment.
correct me if I am wrong here... in my mind tuple is ok for python >= 3.10
typing.Tuple is needed for anything less?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
attr_standardizer.AttrStandardizer._load_modelwith the loading of label encoder and vectorizer.