-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.0 #20
Release 0.1.0 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little confused by this one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to reconsider the version names. Everything else looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some commments and things I'd change... but seems good for now.
bedms/attr_standardizer.py
Outdated
:param int confidence: Confidence threshold for the predictions. | ||
""" | ||
self.schema = schema | ||
self.model = self._load_model() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on self._load_model()
it doesnt seem like I can train my own? Is this possible? Probably a bigger discussion, but this seems tightly coupled to you training it "behind the scenes" and a user can't train their own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presently, the user cannot use bedms
on a model they have trained.
For that, we would have to first make the updated training scripts available to users. And also provide documentation on preprocessing their training scripts.
I agree that this needs further discussion though.
Just add a docs folder and put the change log in there, like we do with many of our other projects. |
``` | ||
or install the latest version from the GitHub repository: | ||
``` | ||
pip install git+https://github.com/databio/bedms.git | ||
``` | ||
|
||
## Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for more documentation than this at the moment? If so, where will it live? The Bedbase docs repository? We could also put the changelog there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Changes:
TODO: