Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.0 #20

Merged
merged 33 commits into from
Sep 16, 2024
Merged

Release 0.1.0 #20

merged 33 commits into from
Sep 16, 2024

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Sep 12, 2024

Changes:

  • Initial release of bedms

TODO:

@khoroshevskyi khoroshevskyi mentioned this pull request Sep 12, 2024
4 tasks
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little confused by this one...

.github/workflows/black.yml Show resolved Hide resolved
__pycache__/bedmess.cpython-312.pyc Outdated Show resolved Hide resolved
attribute_standardizer/_version.py Outdated Show resolved Hide resolved
Copy link
Member

@saanikat saanikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to reconsider the version names. Everything else looks good

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some commments and things I'd change... but seems good for now.

bedms/utils.py Outdated Show resolved Hide resolved
bedms/utils.py Outdated Show resolved Hide resolved
:param int confidence: Confidence threshold for the predictions.
"""
self.schema = schema
self.model = self._load_model()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on self._load_model() it doesnt seem like I can train my own? Is this possible? Probably a bigger discussion, but this seems tightly coupled to you training it "behind the scenes" and a user can't train their own

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presently, the user cannot use bedms on a model they have trained.
For that, we would have to first make the updated training scripts available to users. And also provide documentation on preprocessing their training scripts.
I agree that this needs further discussion though.

@donaldcampbelljr
Copy link
Member

Changes:

  • Initial release of bedms

TODO:

Just add a docs folder and put the change log in there, like we do with many of our other projects.

```
or install the latest version from the GitHub repository:
```
pip install git+https://github.com/databio/bedms.git
```

## Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for more documentation than this at the moment? If so, where will it live? The Bedbase docs repository? We could also put the changelog there as well.

Copy link
Member

@saanikat saanikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@khoroshevskyi khoroshevskyi merged commit 1582598 into master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants