Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Interval Type #55

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Support Interval Type #55

merged 1 commit into from
Jan 15, 2025

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Dec 31, 2024

Supports the new interval type. Would close #51, if it hadn't been closed a little early😄

@rad-pat rad-pat marked this pull request as ready for review January 2, 2025 10:11
@BohuTANG BohuTANG requested a review from hantmac January 3, 2025 02:20
@hantmac
Copy link
Member

hantmac commented Jan 14, 2025

Hi @rad-pat , thanks for your contribution! Would you like to add some tests about the Interval type?

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait some tests

@rad-pat
Copy link
Contributor Author

rad-pat commented Jan 14, 2025

Hi @rad-pat , thanks for your contribution! Would you like to add some tests about the Interval type?

Hi @hantmac , tests are included in the SQLAlchemy test suite, grep the test results for interval to see https://github.com/databendlabs/databend-sqlalchemy/actions/runs/12669519627/job/35307203367#step:7:1

@rad-pat
Copy link
Contributor Author

rad-pat commented Jan 14, 2025

Hi @hantmac , tests are included in the SQLAlchemy test suite, grep the test results for interval to see https://github.com/databendlabs/databend-sqlalchemy/actions/runs/12669519627/job/35307203367#step:7:1

Oh, the tests have not ran here, I will check

@rad-pat
Copy link
Contributor Author

rad-pat commented Jan 14, 2025

My browser grepping is poor, I can see entries for both IntervalTest and PrecisionIntervalTest e.g.

[gw0] PASSED tests/test_sqlalchemy.py::IntervalTest_databend+databend_1_2_680::test_literal 

So, all good for tests👍

@hantmac hantmac merged commit 59e8dc8 into databendlabs:main Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat - Add support for new interval type
3 participants