-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove fake GPS, add newsflash GPS #2738
base: dev
Are you sure you want to change the base?
Conversation
18231f9
to
6b0cb2e
Compare
6b0cb2e
to
35cf0d6
Compare
@ziv17 can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atalyaalon , see my comment below.
e4ddd73
to
68e763a
Compare
@ziv17 Thanks for the feedback Updated per your comments—please review again :) |
def is_included(self): | ||
return self.request_params.gps is not None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is safer to do
return self.request_params.gps and self.request_params.gps.get("lon") and self.request_params.gps.get
No description provided.