add None values when resolution fields not relevant #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaked-hayek
approved these changes
May 30, 2024
atalyaalon
force-pushed
the
2663-location-qualification-bug
branch
2 times, most recently
from
977144b to
59c8c05
Compare
atalyaalon
force-pushed
the
2663-location-qualification-bug
branch
from
59c8c05 to
e6f52db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves use cases when resolution changes (from urban to sub-urban and vice versa ) and we want the news flash location fields relevant to the other resolution to be None.
In addition I added the road_segment_name update (in addition to road_segment_id that already updates) AND sanity check that road1 equals to the road number of the road_segment_id
@tkalir @shaked-hayek can you please review this small pr?