Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2573 widget selection by current params #2574

Merged

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Feb 23, 2024

closes #2573

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.04%. Comparing base (8c895fc) to head (3ce1f88).

Files Patch % Lines
...dgets/urban_widgets/vision_zero_10_50_90_widget.py 70.00% 3 Missing ⚠️
anyway/infographics_utils.py 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2574      +/-   ##
==========================================
+ Coverage   52.96%   53.04%   +0.07%     
==========================================
  Files         119      119              
  Lines        9834     9849      +15     
==========================================
+ Hits         5209     5224      +15     
  Misses       4625     4625              
Flag Coverage Δ
unittests 53.04% <83.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 force-pushed the 2573-widget-selection-by-current-params branch from b5f1152 to 3ce1f88 Compare February 23, 2024 13:13
@ziv17 ziv17 marked this pull request as ready for review February 23, 2024 13:42
@ziv17 ziv17 requested a review from atalyaalon February 23, 2024 13:42
@atalyaalon atalyaalon merged commit e8db8d5 into data-for-change:dev Feb 23, 2024
3 checks passed
@atalyaalon
Copy link
Collaborator

Great work @shaniwein and @ziv17

@ziv17 ziv17 deleted the 2573-widget-selection-by-current-params branch February 23, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infographic Widgets - Support widget selection also according to current request params
4 participants