Remove unused functions and classes #2427
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## dev #2427 +/- ##
==========================================
+ Coverage 54.20% 54.85% +0.65%
==========================================
Files 115 114 -1
Lines 9355 9158 -197
==========================================
- Hits 5071 5024 -47
+ Misses 4284 4134 -150
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| raise ValueError(f"{non_urban_intersection_hebrew}: could not find " | ||
| f"SuburbanJunction with that name") | ||
| return res.non_urban_intersection | ||
|
|
There was a problem hiding this comment.
@ziv17 are we using these functions in future prs?
There was a problem hiding this comment.
Hi @atalyaalon I assume they will be used when we will add suburban junction resolution.
| @@ -84,52 +84,6 @@ def add_news_flash_to_cache(news_flash: NewsFlash): | |||
| return False | |||
|
|
|||
|
|
|||
| def get_infographics_data_from_cache(news_flash_id, years_ago) -> Dict: | |||
There was a problem hiding this comment.
Nice work!
I favor removing unused code.
There are a few geo-location functions that look non trivial. Maybe we can keep them on a commit with specific tag that will allow locating them later, or in a specific file with a comment that they are kept just-in-case? I think that such non-perfect solutions are still better than keep it in the code.
The smaller unused functions I think we should remove.
The two suburban junction methods will be probably used when we will support that resolution. On the other hand, they are simple and can be written again if and when they will be needed.
Fix #2329.
Some functions may be used. Others can be considered useful to keep; we should mark those as unused.