-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weather data infographic [don't merge] #1551
Draft
Hedingber
wants to merge
3
commits into
data-for-change:dev
Choose a base branch
from
Hedingber:add_weather_infographic
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import logging | ||
|
||
from anyway.app_and_db import db | ||
from anyway.models import ( | ||
AccidentMarker, | ||
AccidentWeather, | ||
) | ||
from anyway.parsers.cbs.weather_interpolator import get_weather | ||
|
||
|
||
def ensure_accidents_weather_data(start_date=None, filters=None): | ||
""" | ||
:param start_date: Add start date filter to the query that lists accident markers to add weather data to | ||
:param filters: additional filters to add to the query that lists accident markers to add weather data to | ||
This is used mainly for testing - format DD-MM-YYYY | ||
:returns: int representing the number of accidents to which weather data was added | ||
""" | ||
logging.info(f"Ensuring accidents weather data {start_date} {filters}") | ||
query = db.session.query(AccidentMarker).filter(AccidentMarker.weather_data == None) | ||
if start_date: | ||
query = query.filter(AccidentMarker.created > start_date) | ||
if filters is not None: | ||
query = query.filter(*filters) | ||
accident_markers_to_update = query.all() | ||
if accident_markers_to_update: | ||
logging.debug( | ||
f"Found accident markers without weather data. {len(accident_markers_to_update)}" | ||
) | ||
accidents_weather_data = [] | ||
for accident_marker in query.all(): | ||
weather_data = get_weather( | ||
accident_marker.latitude, accident_marker.longitude, accident_marker.created.isoformat() | ||
) | ||
accidents_weather_data.append( | ||
{ | ||
"accident_id": accident_marker.id, | ||
"provider_and_id": accident_marker.provider_and_id, | ||
"provider_code": accident_marker.provider_code, | ||
"accident_year": accident_marker.accident_year, | ||
"rain_rate": weather_data["rain"], | ||
} | ||
) | ||
if accidents_weather_data: | ||
logging.debug(f"Adding weather data to accidents. {accidents_weather_data}") | ||
db.session.bulk_insert_mappings(AccidentWeather, accidents_weather_data) | ||
db.session.commit() | ||
logging.debug("Finished filling accidents weather data") | ||
return len(accident_markers_to_update) if accident_markers_to_update else 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
.. as caused by rain
?