-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Array API 2024.12 binary ops vs. Python scalars #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
scalar_binary_ops
branch
from
January 29, 2025 15:49
0d80eff
to
2c32ae3
Compare
crusaderky
changed the title
DNM ENH: Array API 2024.12 binary ops vs. Python scalars
ENH: Array API 2024.12 binary ops vs. Python scalars
Jan 29, 2025
crusaderky
commented
Jan 29, 2025
crusaderky
commented
Jan 29, 2025
|
||
def test_all_python_scalars(self): | ||
with pytest.raises(TypeError, match="Unrecognized"): | ||
kron(1, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does NOT fail if xp=jax.numpy, because xp_lazy_function converts everything to jax.
crusaderky
force-pushed
the
scalar_binary_ops
branch
from
January 29, 2025 16:22
2c32ae3
to
6a15d6d
Compare
lucascolley
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great overall, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement 2024.12 rules for
kron
,isclose
, andsetdiff1d
for when a binary operation runs on an Array API object and a python scalar.https://data-apis.org/array-api/draft/API_specification/type_promotion.html#mixing-arrays-with-python-scalars