Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Quote regex to avoid syntax error #58

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

matthewfeickert
Copy link
Contributor

  • Regex on tag must be quoted to avoid YAML syntax error.

Amends PR #51

@asmeurer The CI is failing on merge to main as when you added the regex for the tags to PR #51 I didn't check it on my fork (when debugging I had removed the branch and tag block to run on push). The regex needs to be quoted, else a YAML syntax error occurs.

* Regex on tag must be quoted to avoid YAML syntax error.
@matthewfeickert
Copy link
Contributor Author

matthewfeickert commented Sep 12, 2023

Evidence that this works and you won't have to keep dealing with slightly wrong CI:

$ git diff origin/ci/fix-regex 
diff --git a/.github/workflows/publish-package.yml b/.github/workflows/publish-package.yml
index 35f087d..91a276f 100644
--- a/.github/workflows/publish-package.yml
+++ b/.github/workflows/publish-package.yml
@@ -3,6 +3,7 @@ on:
   push:
     branches:
     - main
+    - debug/workflow
     tags:
     - '[0-9]+.[0-9]+'
     - '[0-9]+.[0-9]+.[0-9]+'

image

@matthewfeickert matthewfeickert mentioned this pull request Sep 12, 2023
@asmeurer asmeurer merged commit ae2d029 into data-apis:main Sep 12, 2023
@matthewfeickert matthewfeickert deleted the ci/fix-regex branch September 12, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants