Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #130

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 13, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from d4765b1 to 000e836 Compare March 25, 2024 21:18
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 000e836 to e16097b Compare April 1, 2024 21:34
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from dad1c2b to b767c9c Compare April 22, 2024 21:13
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from b767c9c to 64f5982 Compare April 29, 2024 21:49
updates:
- [github.com/psf/black: 24.2.0 → 24.4.2](psf/black@24.2.0...24.4.2)
- [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.2.2...v0.4.3)
- [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 64f5982 to a91b987 Compare May 6, 2024 21:26
@lgray
Copy link
Collaborator

lgray commented May 6, 2024

@martindurant what has broken here?

@martindurant
Copy link
Collaborator

I swear I replied to this already...

There seem to be two separate things going on:

  • one in dask-expr/blockwise, original exception
    AttributeError: 'HighLevelGraph' object has no attribute '_all_external_keys'
  • the "spans" exception which is hist-specific, possibly since v1.4.1

@lgray
Copy link
Collaborator

lgray commented May 8, 2024

Probably this PR got closed and re-opened and I still haven't had time to go chase down what happened in the HLG interface to remove _all_external_keys.

@lgray
Copy link
Collaborator

lgray commented May 8, 2024

So one weird thing here is that the AttributeException that's causing that failure should be caught in get_all_external_keys which is what is being called. This must be some pytest configuration thing?

@martindurant
Copy link
Collaborator

I believe it's spread across dask and dask-expr, and probably to do with the latter being extended to (some) array situations. This will be super annoying!

@martindurant
Copy link
Collaborator

  • the version of hist doesn't seem to matter
  • Somehow, during compute, the dask-dataframe is still a dask-dataframe while evaluating tasks; it should be the pandas-dataframe associated with one partition.

@martindurant
Copy link
Collaborator

bisect says it's dask/dask#10977 (dask-expr got turned on, so this is super unhelpful)

@lgray
Copy link
Collaborator

lgray commented May 9, 2024

Can we turn off dask-expr in our tests? Our primary use case is dask-awkward and boost-histograms.

@martindurant
Copy link
Collaborator

Like this, I think. I assume this could be in the dask config files

DASK_DATAFRAME__QUERY_PLANNING=False

@martindurant
Copy link
Collaborator

dask.config.set("dataframe.query-planning", False)

@martindurant martindurant merged commit c301f43 into main May 10, 2024
19 checks passed
@martindurant martindurant deleted the pre-commit-ci-update-config branch May 10, 2024 18:46
@martindurant
Copy link
Collaborator

OK, well it's green, but eventually we want dask-histogram to work happily with dask-expr too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants