-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #130
Conversation
d4765b1
to
000e836
Compare
000e836
to
e16097b
Compare
dad1c2b
to
b767c9c
Compare
b767c9c
to
64f5982
Compare
updates: - [github.com/psf/black: 24.2.0 → 24.4.2](psf/black@24.2.0...24.4.2) - [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.2.2...v0.4.3) - [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2)
64f5982
to
a91b987
Compare
@martindurant what has broken here? |
I swear I replied to this already... There seem to be two separate things going on:
|
Probably this PR got closed and re-opened and I still haven't had time to go chase down what happened in the HLG interface to remove |
So one weird thing here is that the |
I believe it's spread across dask and dask-expr, and probably to do with the latter being extended to (some) array situations. This will be super annoying! |
|
bisect says it's dask/dask#10977 (dask-expr got turned on, so this is super unhelpful) |
Can we turn off dask-expr in our tests? Our primary use case is dask-awkward and boost-histograms. |
Like this, I think. I assume this could be in the dask config files
|
|
OK, well it's green, but eventually we want dask-histogram to work happily with dask-expr too. |
updates: