-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abci state sync #2413
Open
ogabrielides
wants to merge
17
commits into
v2.0-dev
Choose a base branch
from
feat/abci-state-sync
base: v2.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,386
−700
Open
feat: abci state sync #2413
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2d60300
feat: state sync
ogabrielides 134855b
feat: move state sync read operations in consensus app
ogabrielides c00ecbd
fixes for checkpoints_path
ogabrielides 420f84c
suggestions
ogabrielides 1512e85
fix: correct return value for offer_snapshot
ogabrielides 94777c7
refactor: more logs for load_snapshot_chunk API
ogabrielides caed905
fix: spelling
ogabrielides cacdc8c
temp
ogabrielides c686f27
increased snapshots max and freq
ogabrielides e6bb363
fix: return CompleteSnapshot on success
ogabrielides 3b9e2a2
refactor: moved read state_sync into check_tx
ogabrielides 667a3c6
chore: updated tenderdash-abci
ogabrielides a876678
refactor: remove list_snapshots load_snapshot_chunk from consensus app
ogabrielides 76a0576
feat: added finalize_snapshot
ogabrielides 3b80c45
feat: snapshot finalize
ogabrielides 08b7854
fix: correct handling of last_commited_block
ogabrielides a41e993
chore: added logs for info and finalize_snapshot
ogabrielides File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
The codebase has a proper default production path (
/var/lib/dash-platform/data
), but it's being overridden by environment files to use temporary storage:.env.mainnet
:DB_PATH=/tmp/db
.env.testnet
:DB_PATH=/tmp/db
This configuration will lead to data loss on system reboot. Update the environment files to use persistent storage paths instead of
/tmp/db
.🔗 Analysis chain
Verify database paths for production environments.
Both
CHECKPOINTS_PATH
andGROVEDB_LATEST_FILE
inherit fromDB_PATH
which is set to/tmp/db
. While this is fine for local development, using/tmp
in production could lead to data loss as it's typically cleared on system reboot.Run this script to check if there are any production environment files with similar configuration:
Also applies to: 19-19
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 702
Script:
Length of output: 2638