chore(release): update changelog and bump version to 1.8.0-dev.2 #2404
Conversation
WalkthroughThis pull request represents a comprehensive version update across multiple packages in the Dashpay platform, incrementing versions from Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🔇 Additional comments (2)
CHANGELOG.md (2)
1-29: LGTM! Well-structured changelog entry for v1.8.0-dev.2
The changelog follows conventional format and clearly documents important changes including:
- Breaking changes affecting node upgrades and build requirements
- Critical bug fixes for network and voting functionality
- Notable performance improvements
17-17: Notable performance improvement: 3x reduction in JS binding size
The DPP module's JavaScript binding size has been reduced by a factor of 3, which should improve load times and memory usage.
| * On epoch 13, masternode vote state transition validation logic will be changed. Nodes which aren't upgraded to this version will halt (#2397) | ||
| * Rust 1.83 is required to build the project (#2398) |
There was a problem hiding this comment.
💡 Codebase verification
Based on the PR description and code search results, I can now provide the final response:
Critical breaking change: Masternode vote validation fix requires node upgrade by epoch 13
The masternode voting system was broken in protocol version 6 due to incorrect nonce validation against owner identity instead of voting identity. This emergency hard fork fixes the validation by using the correct voting identity nonce starting from epoch 13. All nodes must upgrade before epoch 13 to avoid halting.
- PR fix!: emergency hard fork to fix masternode voting #2397 implements this critical fix
- Nodes running older versions will halt at epoch 13 due to incompatible vote validation logic
🔗 Analysis chain
Critical breaking change: Masternode vote validation changes require node upgrades
Nodes that are not upgraded to this version will halt at epoch 13 due to changes in masternode vote state transition validation logic.
Let me check the referenced PR for more details about this breaking change.
Let me check the code changes related to this breaking change.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any references to the breaking change in code
rg -A 5 "masternode vote state transition validation"
Length of output: 851
Script:
#!/bin/bash
# Check PR #2397 for more details about the breaking change
gh pr view 2397 --json title,body,commits
# Look for any code changes related to masternode voting validation
rg -A 5 "masternode.*vote.*validation"
Length of output: 65620
Script:
#!/bin/bash
# Look for code changes related to masternode voting validation
rg -A 5 "voting.*identity.*nonce"
rg -A 5 "owner.*identity.*nonce"
Length of output: 4259
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
1.8.0-dev.2.Bug Fixes
dashmatemodule.Documentation
CHANGELOG.mdto reflect changes across versions.Chores