more fixes

dashpay · Aug 7, 2024 · 97ea8d7 · 97ea8d7
1 parent c96eda2
commit 97ea8d7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests-rs-drive-abci.yml b/.github/workflows/tests-rs-drive-abci.yml
@@ -238,7 +238,7 @@ jobs:
         uses: ./.github/actions/rust
 
       - name: Run upgrade fork tests
-        run: cargo test --package=drive-abci --test=strategy_tests::upgrade_fork_tests --all-features --locked
+        run: cargo test --package=drive-abci --test=strategy_tests --all-features --locked -- upgrade_fork_tests
         env:
           RUSTC_WRAPPER: sccache
           SCCACHE_BUCKET: multi-runner-cache-x1xibo9c

diff --git a/packages/rs-drive-abci/src/error/execution.rs b/packages/rs-drive-abci/src/error/execution.rs
@@ -90,7 +90,7 @@ pub enum ExecutionError {
 
     /// A protocol upgrade incoherence error occurred.
     #[error("protocol upgrade incoherence error: {0}")]
-    ProtocolUpgradeIncoherence(&'static str),
+    ProtocolUpgradeIncoherence(String),
 
     /// Data is missing from the drive.
     #[error("drive missing data error: {0}")]

diff --git a/...c/execution/platform_events/protocol_upgrade/check_for_desired_protocol_upgrade/v0/mod.rs b/...c/execution/platform_events/protocol_upgrade/check_for_desired_protocol_upgrade/v0/mod.rs
@@ -37,7 +37,7 @@ impl<C> Platform<C> {
         if versions_passing_threshold.len() > 1 {
             return Err(Error::Execution(
                 ExecutionError::ProtocolUpgradeIncoherence(
-                    "only at most 1 version should be able to pass the threshold to upgrade",
+                    format!("only at most 1 version should be able to pass the threshold to upgrade, got versions [{}]", versions_passing_threshold.iter().map(|protocol_version| protocol_version.to_string()).collect::<Vec<_>>().join(", "))
                 ),
             ));
         }