feat(wasm-dpp): add extra methods for state transitions #4948
Annotations
10 warnings and 1 notice
Run clechasseur/rs-clippy-check@v3:
packages/rs-platform-value/src/inner_value.rs#L364
warning: elided lifetime has a name
--> packages/rs-platform-value/src/inner_value.rs:364:66
|
364 | pub fn get_array_slice<'a>(&'a self, key: &'a str) -> Result<&[Value], Error> {
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/document_transition/mod.rs#L171
warning: function cannot return without recursing
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/document_transition/mod.rs:171:5
|
171 | fn entropy(&self) -> Vec<u8> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
172 | self.entropy()
| -------------- recursive call site
|
= help: a `loop` may express intention better if this is on purpose
= note: `#[warn(unconditional_recursion)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/document/state_transition/document_batch_transition/document_transition/document_create_transition.rs#L97
warning: unneeded unit return type
--> packages/wasm-dpp/src/document/state_transition/document_batch_transition/document_transition/document_create_transition.rs:97:80
|
97 | pub fn set_identity_contract_nonce(&mut self, identity_contract_nonce: u64) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/document/state_transition/document_batch_transition/document_transition/document_create_transition.rs#L93
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> packages/wasm-dpp/src/document/state_transition/document_batch_transition/document_transition/document_create_transition.rs:93:9
|
93 | self.inner.base().identity_contract_nonce() as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.inner.base().identity_contract_nonce()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/identity/state_transition/identity_credit_transfer_transition/transition.rs#L118
warning: unneeded unit return type
--> packages/wasm-dpp/src/identity/state_transition/identity_credit_transfer_transition/transition.rs:118:44
|
118 | pub fn set_nonce(&mut self, nonce: u64) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/identity/state_transition/identity_credit_transfer_transition/transition.rs#L104
warning: casting to the same type is unnecessary (`u16` -> `u16`)
--> packages/wasm-dpp/src/identity/state_transition/identity_credit_transfer_transition/transition.rs:104:9
|
104 | self.0.user_fee_increase() as u16
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.user_fee_increase()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs#L179
warning: unneeded unit return type
--> packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs:179:71
|
179 | pub fn set_identity_contract_nonce(&mut self, identity_nonce: u64) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs#L165
warning: casting to the same type is unnecessary (`u16` -> `u16`)
--> packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs:165:9
|
165 | self.0.user_fee_increase() as u16
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.user_fee_increase()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/utils.rs#L25
warning: bound is defined in more than one place
--> packages/wasm-dpp/src/utils.rs:25:24
|
25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue>
| ^
26 | where
27 | D: for<'de> serde::de::Deserialize<'de> + 'static;
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/wasm-dpp/src/utils.rs#L24
warning: methods `with_serde_to_platform_value_map` and `with_serde_into` are never used
--> packages/wasm-dpp/src/utils.rs:24:8
|
19 | pub trait ToSerdeJSONExt {
| -------------- methods in this trait
...
24 | fn with_serde_to_platform_value_map(&self) -> Result<BTreeMap<String, Value>, JsValue>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue>
| ^^^^^^^^^^^^^^^
|
Post Setup sccache
100% - 203 hits, 0 misses, 0 errors
|
Loading