Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump bls to dashpay bls 1.3.2 and rust 1.80.x adjustements #95

Merged
merged 8 commits into from
Oct 7, 2024
Merged

chore: bump bls to dashpay bls 1.3.2 and rust 1.80.x adjustements #95

merged 8 commits into from
Oct 7, 2024

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 6, 2024 •
edited
Loading

Issue being fixed or feature implemented

  • bumped bls signatures to dashpay bls version 1.3.2 and adjusted code
  • adjusted to Rust version 1.80.x

What was done?

How Has This Been Tested?

tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pankcuf and others added 6 commits August 26, 2024 22:45
@pankcuf
chore: update some deps 1.80
a6370af
@ogabrielides
Squashed commit of the following:
188e5b4 
commit d1cec6a
Author: Konstantin Akimov <[email protected]>
Date:   Tue Aug 27 15:03:22 2024 +0700

    fix: more fixes for serde

commit da69194
Author: Konstantin <[email protected]>
Date:   Mon Aug 26 22:29:31 2024 +0800

    fix: multiple fixes for dash-spv-masternode-processor

commit 9ab2ec4
Author: Konstantin <[email protected]>
Date:   Fri Aug 23 15:33:38 2024 +0800

    fix: bump bls-signature version to the latest changes

commit f025b65
Author: Konstantin <[email protected]>
Date:   Fri Aug 23 15:24:27 2024 +0800

    fix: update cargo.lock - to make it compileable at least

commit 603deb0
Author: Konstantin <[email protected]>
Date:   Wed Aug 21 22:05:46 2024 +0800

    fix: multipe fixes build.sh script: fix rm; set -e; bump rust version
@ogabrielides
temp fix
51d2ed5
@knst
new git revision for bls signature - should works now! 4a11186d078be8…
05bb5b9 
…560b448d16a2bea16473dc1806
@ogabrielides
bump bls dashpay repo
3b339dd
@ogabrielides
bump libc
396ab83
@ogabrielides ogabrielides changed the title chore: bump bls to dashpay repo. and rust 1.8xx adjustements chore: bump bls to dashpay repo and rust 1.8xx adjustements Oct 6, 2024
@ogabrielides ogabrielides changed the title chore: bump bls to dashpay repo and rust 1.8xx adjustements chore: bump bls to dashpay bls 1.3.2 and rust 1.8xx adjustements Oct 6, 2024
@ogabrielides ogabrielides marked this pull request as draft October 7, 2024 12:29
@ogabrielides ogabrielides marked this pull request as ready for review October 7, 2024 16:11
@ogabrielides
Copy link
Collaborator Author

CI failure will be fixed in dashpay/bls-signatures#95

@ogabrielides ogabrielides changed the title chore: bump bls to dashpay bls 1.3.2 and rust 1.8xx adjustements chore: bump bls to dashpay bls 1.3.2 and rust 1.80.x adjustements Oct 7, 2024
pankcuf
pankcuf requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please bump up versions in podspec and crate:

@ogabrielides ogabrielides requested a review from pankcuf October 7, 2024 18:17
HashEngineering
HashEngineering approved these changes Oct 7, 2024
View reviewed changes
Copy link

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. builds for me without errors

@ogabrielides ogabrielides merged commit b424aa0 into dashpay:main Oct 7, 2024
1 of 2 checks passed
@ogabrielides ogabrielides deleted the swtich_bls_dashpay branch October 7, 2024 21:08
ogabrielides added a commit to ogabrielides/dash-shared-core that referenced this pull request Oct 8, 2024
@ogabrielides
Merge pull request dashpay#95 from ogabrielides/swtich_bls_dashpay
a6437f1 
chore: bump bls to dashpay bls 1.3.2 and rust 1.80.x adjustments
@ogabrielides ogabrielides mentioned this pull request Oct 8, 2024
Merged
5 tasks
@pankcuf pankcuf mentioned this pull request Oct 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

@pankcuf pankcuf pankcuf approved these changes

@Syn-McJ Syn-McJ Awaiting requested review from Syn-McJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogabrielides @pankcuf @HashEngineering @knst