Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation for any testnet destroy operation #668

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

ktechmidas
Copy link
Contributor

Issue being fixed or feature implemented

Confirmation before issuing any destroy command on testnet, explaining that platform will likely stall forever if it is run.

What was done?

Confirmation + a way to bypass it with the prompt

How Has This Been Tested?

./bin/destroy -t=all testnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Contributor

@vivekgsharma vivekgsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktechmidas ktechmidas merged commit 460e182 into v1.0-dev Dec 27, 2024
1 check passed
@ktechmidas ktechmidas deleted the do-not-destroy branch December 27, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants