fix: issues #328
Merged
fix: issues #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 4efa7410676e25e36e52cdae9e5d1a5944641776 Author: Lukas Rosenthaler <[email protected]> Date: Wed Jul 1 11:43:27 2020 +0200 delete large file commit 8693fbe66ccce0b1a679aecb05eca9a56ab16151 Author: Lukas Rosenthaler <[email protected]> Date: Wed Jul 1 10:52:56 2020 +0200 Handling of non-image files in knora.json commit 641efa3c62499df1f949b29fe93652e9f4d78c71 Author: Lukas Rosenthaler <[email protected]> Date: Mon Jun 29 18:09:08 2020 +0200 … commit 394d96c5b52e00d3f037bba2551ec0a330c20946 Author: Lukas Rosenthaler <[email protected]> Date: Mon Jun 29 18:08:58 2020 +0200 Added support for non-imagefiles commit eb792e1 Author: Lukas Rosenthaler <[email protected]> Date: Wed Jun 24 11:12:17 2020 +0200 Small fixes commit 547d83d Author: Lukas Rosenthaler <[email protected]> Date: Tue Jun 23 01:27:33 2020 +0200 ... commit e0e6f3a Author: Lukas Rosenthaler <[email protected]> Date: Tue Jun 23 01:27:19 2020 +0200 Frist commit of new branch
commit 2e4253b Author: André Kilchenmann <[email protected]> Date: Thu Jun 25 15:38:46 2020 +0200 chore(ci): Update release notes on each release (#327) commit 0306c33 Author: Ivan Subotic <[email protected]> Date: Wed Jun 24 21:07:58 2020 +0200 build: fix publish (#326) commit 7cfc5c6 Author: Ivan Subotic <[email protected]> Date: Wed Jun 24 19:38:39 2020 +0200 build: fix publish (#325) commit d04725a Author: Ivan Subotic <[email protected]> Date: Wed Jun 24 17:46:12 2020 +0200 feature: add IIIF 3.0 support (#324)
|
Please use my version for conficting files... |
|
cool, thanks for resolving so many issues :-) a lot of work :-) |
subotic
requested changes
Jul 3, 2020
|
Which files are missing??
…Sent from my iPad
On 3 Jul 2020, at 06:33, Ivan Subotic <[email protected]> wrote:
@subotic requested changes on this pull request.
Besides the failing test because of missing files, everything looks good, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#328 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJX3TFZLNDI46YY646RAMLRZVNRDANCNFSM4OPJ67AQ>.
|
subotic
approved these changes
Jul 6, 2020
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest closes the following issues: