This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Fix tests in the viewer module #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue, decimal-value, integer-value, interval-value + exclude temporarily tests of search-results
…-value, external-res-value, geoname-value, uri-value
# Conflicts: # projects/knora/viewer/src/lib/property/external-res-value/external-res-value.component.spec.ts
…, other tests commented out temporarily
…, other tests commented out temporarily
…cause missing in the lib
…issing imports from knora/api
…e MockFactory from knora/api is needed
kilchenmann
approved these changes
Dec 10, 2019
| @@ -1,10 +1,33 @@ | |||
| import { Component, DebugElement, OnInit, ViewChild } from '@angular/core'; | |||
| import { async, ComponentFixture, TestBed } from '@angular/core/testing'; | |||
| import { By } from '@angular/platform-browser'; | |||
| import { ReadGeomValue } from '@knora/core'; | |||
| import { ReadGeomValue } from '@knora/api'; | |||
| import { ParseReadGeomValue } from '@knora/api/src/models/v2/resources/values/read/read-geom-value'; | |||
There was a problem hiding this comment.
ParseReadGeomValue has no exported member in knora-api-js-lib. @flavens can you write an issue about that in knora-api-js-lib. Probably there are more like this...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get imports from knora/api lib
Fix broken tests when it is possible
Some tests are commented out because it requires a MockFactory and exports from knora/api lib.
See knora-api-js-lib/issues/121