Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make service work with json (DEV-3930) #146

Merged
merged 52 commits into from
Jul 29, 2024
Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jul 25, 2024

  • Add filter and query params to projects endpoint
  • Add paging to projects endpoint
  • Serve data from json files
  • Fix loading assets in webapp in subpages
  • Introduce project.status to json schemas
  • Remove _*.json data

Basically you can ignore the changes of the *.json files. I have copied over the latest version from the Go service and added the project.status property with the python script from this pr. That also reformatted all json files, hence so many changed lines.

@seakayone seakayone force-pushed the feat/use-draft-meta branch from faf509d to f5e87d0 Compare July 25, 2024 15:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.7%. Comparing base (c453d59) to head (a263a60).

Additional details and impacted files
Files Coverage Δ
dsp-meta-cmd/src/main-server.rs 0.0% <ø> (ø)
dsp-meta-cmd/src/main-validator.rs 0.0% <ø> (ø)
...p-meta/src/api/handler/project_metadata_handler.rs 0.0% <ø> (-40.0%) ⬇️
dsp-meta/src/api/model/project_metadata_dto.rs 0.0% <ø> (-33.4%) ⬇️
dsp-meta/src/api/router.rs 99.0% <ø> (-0.2%) ⬇️
dsp-meta/src/domain/model/draft_model.rs 82.6% <ø> (ø)
dsp-meta/src/domain/model/error.rs 0.0% <ø> (ø)
dsp-meta/src/domain/model/json_schema_validator.rs 81.8% <ø> (ø)
...eta/src/domain/service/project_metadata_service.rs 50.0% <ø> (-41.0%) ⬇️
dsp-meta/src/domain/service/repository_contract.rs 0.0% <ø> (-23.6%) ⬇️
... and 2 more

@seakayone seakayone marked this pull request as ready for review July 26, 2024 07:12
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

data/add_status.python Outdated Show resolved Hide resolved
data/add_status.python Outdated Show resolved Hide resolved
dsp-meta-cmd/src/main-server.rs Show resolved Hide resolved
dsp-meta/src/api/router.rs Show resolved Hide resolved
@seakayone seakayone changed the title feat: Make service work with json feat: Make service work with json (DEV-3930) Jul 29, 2024
Copy link

linear bot commented Jul 29, 2024

Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all improvements and also cleanup with some consts! Overall looks good, but there are few things I asked in comments below. The ones regarding formatting are rather for further discussion, not blocking comments.

data/json/Rome.json Show resolved Hide resolved
docs/domain_model/domain-entities.puml Outdated Show resolved Hide resolved
</a>
{/if}
</div>
{#if ($projectMetadata?.project.url || $projectMetadata?.project.secondaryURL) && !$isTestEnvironment}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for me - check it in detail if it could be improved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOt yet, but if I will have, will open a PR.

web-frontend/src/store.ts Outdated Show resolved Hide resolved
web-frontend/src/store.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants