-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make service work with json (DEV-3930) #146
Conversation
faf509d
to
f5e87d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
… to a build-frontend and cargo clean before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all improvements and also cleanup with some consts! Overall looks good, but there are few things I asked in comments below. The ones regarding formatting are rather for further discussion, not blocking comments.
</a> | ||
{/if} | ||
</div> | ||
{#if ($projectMetadata?.project.url || $projectMetadata?.project.secondaryURL) && !$isTestEnvironment} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for me - check it in detail if it could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have an idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOt yet, but if I will have, will open a PR.
Co-authored-by: Marcin Procyk <[email protected]>
_*.json
dataBasically you can ignore the changes of the
*.json
files. I have copied over the latest version from the Go service and added theproject.status
property with the python script from this pr. That also reformatted all json files, hence so many changed lines.