fix: Fix filename regex #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mpro7
commented
Jan 6, 2025
mpro7
commented
- add []{} special characters and improve test
- remove not allowed ? character
- add test for not allowed ? and / characters
mpro7
requested review from
BalduinLandolt,
seakayone and
siers
as code owners
BalduinLandolt
approved these changes
Jan 6, 2025
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
mpro7
deleted the
dev-4478-files-with-angular-brackets-cannot-be-ingested
branch
jnussbaum
reviewed
Jan 7, 2025
jnussbaum
reviewed
Jan 7, 2025
| @@ -13,7 +13,7 @@ final case class AssetFilename private (value: String) extends AnyVal | |||
|
|
|||
| object AssetFilename { | |||
| // Allow letters, numbers, underscores, hyphens, spaces, full stops, comma, single quote, apostrophe and braces | |||
| private val regex = """^[\p{L}\p{N}_\- .,'`()+=!?<>|]+$""".r | |||
| private val regex = """^[\p{L}\p{N}_\- .,'`+=!<>|()\[\]\{\}]+$""".r | |||
There was a problem hiding this comment.
I think that () need to be escaped as well, because they are reserved characters in regex?
There was a problem hiding this comment.
They were not escaped before and all tests passed but you might have right.
mpro7
pushed a commit
that referenced
this pull request
Jan 13, 2025
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.0...v0.17.0) (2025-01-07) ### Maintenances * Remove deprecated maintenance actions from API ([#314](#314)) ([1150048](1150048)) * Update copyright 2025 ([#312](#312)) ([c372a2b](c372a2b)) ### Enhancements * Show audio files in asset-overview-report seperately (DEV-4490) ([#313](#313)) ([12ea2aa](12ea2aa)) ### Bug Fixes * Fix filename regex ([#316](#316)) ([679c79e](679c79e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.