-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add DSP-META to docs #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, we don't bump the submodules to the latest state. Rather, we wait until a deployment happens, and then we bump the submodules to the state of the version that was deployed. That means, the submodules should always be at the state defined in release.mk.
When you're on it, would you like to fix the wrong version of DSP-TOOLS in release.mk? It should be "v9.0.2", which is the latest clean release. (I think I once added the commit hash to make an informal after-deployment of the docs).
Good thing you made me double-check! It was actually broken due to a wrong meta tag... And, yes, I know that we normally don't update the submodules until the deployment, but I figured it doesn't matter as long as the docs don't get deployed. Should I revert? |
No, you can leave it. Now, the submodules are in sync with release.mk, so that's okay. |
But now the tests fail 🙈 |
INGEST := "v0.12.3" | ||
META := "dsp-meta-v2.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a unfortunate setup :( but nothing related to this repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I thought the same
No description provided.