Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update annotations tab when switching to a compound without page (DEV-4171) #1997

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: update annotations tab when switching to a compound without page (DEV-4171) #1997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5abe076
fix: update annotations tab when switching to a compound without inco…
domsteinbach Dec 10, 2024
37ff300
Merge branch 'main' into feature/dev-4171-anton-webern-update-annotat…
irmastnt Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libs/vre/resource-editor/resource-editor/src/lib/compound/compound.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { BehaviorSubject } from 'rxjs';
export class CompoundService {
compoundPosition!: DspCompoundPosition;

private _incomingResource = new BehaviorSubject<DspResource | undefined>(undefined);
incomingResource$ = this._incomingResource.asObservable();
incomingResource = new BehaviorSubject<DspResource | undefined>(undefined);
incomingResource$ = this.incomingResource.asObservable();

private _resource!: DspResource;

Expand Down Expand Up @@ -48,7 +48,7 @@ export class CompoundService {
const incomingImageRepresentations = res as ReadResourceSequence;

if (incomingImageRepresentations.resources.length === 0) {
this._incomingResource.next(undefined);
this.incomingResource.next(undefined);
return;
}
this._resource.incomingRepresentations = incomingImageRepresentations.resources;
Expand All @@ -75,7 +75,7 @@ export class CompoundService {
}

private _reloadViewer(resource: DspResource) {
this._incomingResource.next(resource);
this.incomingResource.next(resource);
this._cd.detectChanges();
}
}
2 changes: 2 additions & 0 deletions libs/vre/resource-editor/resource-editor/src/lib/resource.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ export class ResourceComponent implements OnChanges {
if (this.isCompoundNavigation) {
this._compoundService.onInit(new DspCompoundPosition(countQuery_.numberOfResults), this.resource);
this._cdr.detectChanges();
} else {
this._compoundService.incomingResource.next(undefined);
}
});
}
Expand Down
Loading