Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove datadog #1413

Merged
merged 3 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
env:
# use the read-write access token so that build cache in nx-cloud can be updated
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
# use during publishing to upload src maps to datadog
DATADOG_API_KEY: ${{secrets.DATADOG_API_KEY}}
DATADOG_SITE: ${{vars.DATADOG_SITE}}

jobs:

Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/publish-from-branch.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
name: Publish from branch

env:
# use during publishing to upload src maps to datadog
DATADOG_API_KEY: ${{secrets.DATADOG_API_KEY}}
DATADOG_SITE: ${{vars.DATADOG_SITE}}

on:
workflow_dispatch
jobs:
Expand Down
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ docker-image-tag: ## prints the docker image tag
.PHONY: docker-publish-app
docker-publish-app: app-build-prod ## publish DSP-APP Docker image to Docker-Hub for AMD64 and ARM64
docker buildx build --platform linux/amd64,linux/arm64/v8 --build-arg build_tag=$(BUILD_TAG) -t $(DSP_APP_IMAGE) --push .
# publish source maps to DataDog
npx datadog-ci sourcemaps upload ${CURRENT_DIR}/dist/apps/dsp-app \
--service=dsp-app \
--release-version=${BUILD_TAG} \
--minified-path-prefix=/


.PHONY: docker-publish
docker-publish: docker-publish-app ## publish all Docker images in the monorepo.
Expand Down
7 changes: 2 additions & 5 deletions apps/dsp-app/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { CKEditorModule } from '@ckeditor/ckeditor5-angular';
import { MatJDNConvertibleCalendarDateAdapterModule } from '@dasch-swiss/jdnconvertiblecalendardateadapter';
import { AdvancedSearchComponent } from '@dasch-swiss/vre/advanced-search';
import { DatadogRumService, PendoAnalyticsService } from '@dasch-swiss/vre/shared/app-analytics';
import { PendoAnalyticsService } from '@dasch-swiss/vre/shared/app-analytics';
import {
AppConfigService,
buildTagFactory,
Expand All @@ -19,7 +19,6 @@ import {
} from '@dasch-swiss/vre/shared/app-config';
import { AppDatePickerComponent } from '@dasch-swiss/vre/shared/app-date-picker';
import { AppErrorHandler } from '@dasch-swiss/vre/shared/app-error-handler';
import { AppLoggingService } from '@dasch-swiss/vre/shared/app-logging';
import { NotificationService } from '@dasch-swiss/vre/shared/app-notification';
import {
AppProgressIndicatorComponent,
Expand All @@ -29,9 +28,9 @@ import {
import { NgxsStoreModule } from '@dasch-swiss/vre/shared/app-state';
import {
AppStringLiteralComponent,
HumanReadableErrorPipe,
MultiLanguageTextareaComponent,
MutiLanguageInputComponent,
HumanReadableErrorPipe,
} from '@dasch-swiss/vre/shared/app-string-literal';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { TranslateHttpLoader } from '@ngx-translate/http-loader';
Expand Down Expand Up @@ -357,8 +356,6 @@ export function httpLoaderFactory(httpClient: HttpClient) {
],
providers: [
AppConfigService,
DatadogRumService,
AppLoggingService,
PendoAnalyticsService,
{
provide: DspApiConfigToken,
Expand Down

This file was deleted.

Loading
Loading