fix(dsp-app): Moved reusable form validators to single place. (#DEV-3222) #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-by-adding-the-same-keywords * main: fix: add min and max length to keywords validators (#1379) fix(dsp-app): resource link form (#DEV-3203) (#1377) feat(project form): creating a new project with an existing short code (DEV-3204) (#1368) # Conflicts: # apps/dsp-app/src/app/project/reusable-project-form/reusable-project-form.component.ts
…le form validators to single place. (#DEV-3222)
…on-by-adding-the-same-keywords
…on-by-adding-the-same-keywords * main: fix: auth guard waits for autologin to happen (#1399) fix: autologin logs in with iri from jwt (#1397) fix(dsp-app): fixes no search results section (DEV-3240) (#1398) refactor: new AppErrorHandler (#1396) refactor: remove ngxs storage plugin package (#1395) refactor: authentication flow improved, watch localStorage for changes (#1393) chore(main): release 11.2.0 (#1307) chore: Update dsp-js to v9.1.10 (#1389) fix: advanced search number of results bug (#1388) fix: list item comment get updated (#1386) fix: send gravsearch and search-count request simultaniously (#1380) fix(projects list): deactivating-a-project-not-possible (DEV-3206) (#1366) fix: keywords chip inputs cannot be duplicated (#1382) fix: more readable error message (#1383) fix: cancel button in project form goes back to previous page (#1385)
irmastnt
changed the title
derschnee68
approved these changes
Jan 29, 2024
| @@ -34,6 +34,10 @@ export class HumanReadableErrorPipe implements PipeTransform { | |||
| return 'This is already taken by another entity'; | |||
| } | |||
|
|
|||
| if (error.hasOwnProperty('duplicateExists')) { | |||
| return 'Duplicate exists'; | |||
There was a problem hiding this comment.
Should be more precise and UX friendly:
"There already exists a field with name {name}"
…on-by-adding-the-same-keywords
…on-by-adding-the-same-keywords
irmastnt
deleted the
feature/dev-3222-editing-a-project-description-by-adding-the-same-keywords
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-3222