refactor: make list forms files clearer #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/dsp-app/src/app/app-routing.module.ts # apps/dsp-app/src/app/app.module.ts
# Conflicts: # apps/dsp-app/src/app/app.module.ts
# Conflicts: # apps/dsp-app/src/app/project/list/list-item-form/list-item-form.component.ts # apps/dsp-app/src/app/project/list/list.component.ts
# Conflicts: # apps/dsp-app/src/app/project/list/list-item-form/list-item-form.component.ts
irmastnt
requested changes
Jan 11, 2024
apps/dsp-app/src/app/project/list/action-bubble/action-bubble.component.ts
Outdated
Show resolved
Hide resolved
| askToDeleteListNode() { | ||
| this._dialog | ||
| .afterConfirmation('Do you want to delete this node?', this.node.labels[0].value) | ||
| .pipe(switchMap(() => this._listApiService.deleteListNode(this.node.id))) |
There was a problem hiding this comment.
unsubscribe by using .pipe(take(1))
There was a problem hiding this comment.
dialog automatically unsubscribes
...-app/src/app/project/list/list-item-form/edit-list-item/create-list-item-dialog.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
larger part of the code in the create and edit components is duplicated. I would suggest to make one component.
There was a problem hiding this comment.
I don't agree, as those two codes are clearly different components, it makes the code less readable and is prone to unmaintainable code in case we want to change specific part in the dialog for one or the other case
| styleUrls: ['./list-item.component.scss'], | ||
| template: ` | ||
| <app-list-item-element | ||
| *ngFor="let child of children; let index = index; let first = first; let last = last" |
There was a problem hiding this comment.
add trackBy function to avoid looping through all DOM elements during change detection
apps/dsp-app/src/app/project/list/list-item/list-item.component.ts
Outdated
Show resolved
Hide resolved
irmastnt
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.