fix(activate/deactivate project): subscribe to the observable #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger the response Need to subscribe to trigger the request, otherwise it will not be sent. The request is lazy. Fix also for activating the project.
DEV-2931 Deactivate project functionality in your account does not work anymore
Expected result : Project gets marked as deactivated and does not show up im my Projects anymore Actual Result: Nothing happens - Project stays active |
irmastnt
requested changes
Nov 14, 2023
| @@ -168,6 +171,7 @@ export class ProjectsListComponent implements OnInit { | |||
| const dialogRef = this._dialog.open(DialogComponent, dialogConfig); | |||
|
|
|||
| dialogRef.afterClosed().subscribe((response) => { | |||
| console.log('Dialog was closed', response); | |||
| @@ -195,18 +199,16 @@ export class ProjectsListComponent implements OnInit { | |||
| const uuid = this._projectService.iriToUuid(id); | |||
| // the deleteProject() method in js-lib sets the project's status to false, it is not actually deleted | |||
|
|
|||
| this._dspApiConnection.admin.projectsEndpoint | |||
| this.deactivateSubscription = this._dspApiConnection.admin.projectsEndpoint | |||
| .deleteProject(id) | |||
There was a problem hiding this comment.
instead of creating subscription use .pipe(take(1)), then you dont need to unsubscribe
irmastnt
approved these changes
Nov 14, 2023
domsteinbach
deleted the
feature/dev-2931-deactivate-project-functionality-in-your-account-does-not
branch
irmastnt
added a commit
that referenced
this pull request
Nov 16, 2023
…return-true-observables-that-also * main: chore(main): release 11.1.3 (#1268) fix(date-picker): date-picker doesn't show in advanced search (#1267) chore(main): release 11.1.2 (#1265) fix(results): go back to search form button fix (#1266) fix(advanced-search): undefined error leads to blank page (#1264) chore(main): release 11.1.1 (#1263) fix(results): user unable to execute second fulltext search (#1262) fix(activate/deactivate project): subscribe to the observable (#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to subscribe to the observable to trigger the request, otherwise it will not be sent. The observable is lazy. Fix also for activating the project.
resolves DEV-2931