Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make ontology cache data fields private and move access into methods #3448

Draft
wants to merge 6 commits into
base: wip/minor-refactoring
Choose a base branch
from
Draft

refactor: Make ontology cache data fields private and move access into methods #3448

wants to merge 6 commits into from

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Dec 22, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt mentioned this pull request Dec 22, 2024
Draft
11 tasks
@BalduinLandolt BalduinLandolt force-pushed the wip/refactor-ontology-cache branch from 7b7a620 to ec27abb Compare December 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 will be requested when the pull request is marked ready for review mpro7 is a code owner

@seakayone seakayone Awaiting requested review from seakayone seakayone will be requested when the pull request is marked ready for review seakayone is a code owner

@siers siers Awaiting requested review from siers siers will be requested when the pull request is marked ready for review siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BalduinLandolt