feat: Split license into licenseText and licenseUri (DEV-4398) #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
force-pushed
the
feat/split-license
branch
from
10dcc31 to
c04a032
Compare
seakayone
changed the title
seakayone
requested review from
BalduinLandolt,
mpro7 and
siers
as code owners
seakayone
changed the title
siers
approved these changes
Dec 3, 2024
BalduinLandolt
approved these changes
Dec 3, 2024
mpro7
approved these changes
Dec 3, 2024
| ) = | ||
| for { | ||
| projectService <- ZIO.service[KnoraProjectService] | ||
| prj <- projectService.findByShortcode(Shortcode.unsafeFrom("0001")).someOrFail(new Exception("Project not found")) | ||
| change = prj.copy(copyrightAttribution = copyrightAttribution, license = license) | ||
| change = prj.copy(copyrightAttribution = copyrightAttribution, licenseText = licenseText, licenseUri = licenseUri) |
There was a problem hiding this comment.
Suggested change
| change = prj.copy(copyrightAttribution = copyrightAttribution, licenseText = licenseText, licenseUri = licenseUri) | |
| change = prj.copy(copyrightAttribution, licenseText, licenseUri) |
There was a problem hiding this comment.
This won't compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?